From ce10b4cebd0c57c9699881bce267fa0847c02f7c Mon Sep 17 00:00:00 2001
From: Chris Lawton <chris.lawton@torchbox.com>
Date: Tue, 7 Aug 2018 14:34:33 +0100
Subject: [PATCH] lint codebase
---
.../apply/components/_all-submissions.scss | 2 +-
.../src/sass/apply/components/_feed.scss | 2 +-
.../src/sass/apply/components/_form.scss | 5 +++--
.../src/sass/apply/components/_messages.scss | 22 +++++++++----------
.../src/sass/apply/components/_nav.scss | 5 ++++-
.../sass/apply/components/_pagination.scss | 2 +-
.../src/sass/apply/components/_select2.scss | 6 ++---
.../src/sass/public/components/_grid.scss | 4 ++--
8 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/opentech/static_src/src/sass/apply/components/_all-submissions.scss b/opentech/static_src/src/sass/apply/components/_all-submissions.scss
index bb0ac6032..b846175b0 100644
--- a/opentech/static_src/src/sass/apply/components/_all-submissions.scss
+++ b/opentech/static_src/src/sass/apply/components/_all-submissions.scss
@@ -42,7 +42,7 @@ $table-breakpoint: 'tablet-landscape';
}
}
- &.reviews_stats {
+ &.reviews_stats { // sass-lint:disable-line class-name-format
color: $color--mid-dark-grey;
span {
diff --git a/opentech/static_src/src/sass/apply/components/_feed.scss b/opentech/static_src/src/sass/apply/components/_feed.scss
index df79653ca..651f9162f 100644
--- a/opentech/static_src/src/sass/apply/components/_feed.scss
+++ b/opentech/static_src/src/sass/apply/components/_feed.scss
@@ -85,7 +85,7 @@
&--progress {
width: 100%;
margin: 5px 0 0;
- font-size: map-get($font-sizes, milli);;
+ font-size: map-get($font-sizes, milli);
color: $color--black-50;
@include media-query(small-tablet) {
diff --git a/opentech/static_src/src/sass/apply/components/_form.scss b/opentech/static_src/src/sass/apply/components/_form.scss
index b79baf3f1..4fb6b5b40 100644
--- a/opentech/static_src/src/sass/apply/components/_form.scss
+++ b/opentech/static_src/src/sass/apply/components/_form.scss
@@ -131,7 +131,7 @@
flex-direction: column;
padding: 0;
- .select2 .select2-selection.select2-selection--single {
+ .select2 .select2-selection.select2-selection--single { // sass-lint:disable-line force-element-nesting
border: 0;
border-top: 1px solid $color--mid-grey;
@@ -142,6 +142,7 @@
}
}
+ // so the form can be output in any tag
> * {
flex-basis: auto;
margin: 0;
@@ -201,7 +202,7 @@
-moz-appearance: none; // sass-lint:disable-line no-vendor-prefixes
option {
- background-color: white;
+ background-color: $color--white;
}
}
diff --git a/opentech/static_src/src/sass/apply/components/_messages.scss b/opentech/static_src/src/sass/apply/components/_messages.scss
index 3bec88cdc..509c244c9 100644
--- a/opentech/static_src/src/sass/apply/components/_messages.scss
+++ b/opentech/static_src/src/sass/apply/components/_messages.scss
@@ -1,16 +1,16 @@
.messages {
- width: 100vw;
position: relative;
- left: 50%;
right: 50%;
- margin-left: -50vw;
+ left: 50%;
+ width: 100vw;
margin-right: -50vw;
+ margin-left: -50vw;
&__text {
- max-height:1000px;
+ position: relative;
+ max-height: 1000px;
padding: 15px;
padding-right: 35px;
- position:relative;
border: solid 1px;
&--info {
@@ -18,20 +18,20 @@
border-color: darken($color--pastel-green, 20%);
}
- &--warning{
- color: $color--white;
+ &--warning {
font-weight: bold;
+ color: $color--white;
background: $color--error;
border-color: darken($color--error, 20%);
}
&--hide {
- max-height: 0px;
- padding-top: 0px;
- padding-bottom: 0px;
+ max-height: 0;
+ padding-top: 0;
+ padding-bottom: 0;
border: 0 none;
+ transition: all $transition; // sass-lint:disable-line no-transition-all
transform-origin: top;
- transition: all $transition;
}
}
diff --git a/opentech/static_src/src/sass/apply/components/_nav.scss b/opentech/static_src/src/sass/apply/components/_nav.scss
index 243cd36fd..dc003a247 100644
--- a/opentech/static_src/src/sass/apply/components/_nav.scss
+++ b/opentech/static_src/src/sass/apply/components/_nav.scss
@@ -47,10 +47,13 @@
@include media-query(tablet-portrait) {
display: inline;
- padding: 30px 0;
+ padding: 40px 0;
color: $color--default;
}
+ @include media-query(tablet-landscape) {
+ padding: 30px 0;
+ }
&--active {
&::after {
diff --git a/opentech/static_src/src/sass/apply/components/_pagination.scss b/opentech/static_src/src/sass/apply/components/_pagination.scss
index 67f49b2b5..4b661189e 100644
--- a/opentech/static_src/src/sass/apply/components/_pagination.scss
+++ b/opentech/static_src/src/sass/apply/components/_pagination.scss
@@ -22,7 +22,7 @@
border: 1px solid $color--mid-grey;
&::after {
- position: absolute;;
+ position: absolute;
top: 18.5px;
left: 22.5px;
}
diff --git a/opentech/static_src/src/sass/apply/components/_select2.scss b/opentech/static_src/src/sass/apply/components/_select2.scss
index 39c335195..962f79c87 100644
--- a/opentech/static_src/src/sass/apply/components/_select2.scss
+++ b/opentech/static_src/src/sass/apply/components/_select2.scss
@@ -5,7 +5,7 @@
.select2-container--default,
&.select2-container--default {
- width: 100% !important;
+ width: 100% !important; // sass-lint:disable-line no-important
.select2-selection--single {
height: 55px;
@@ -54,8 +54,8 @@
.select2-container {
&--default {
.select2-results__option--highlighted[aria-selected] {
- color: $color--default !important;
- background-color: transparentize($color--primary, 0.9) !important;
+ color: $color--default !important; // sass-lint:disable-line no-important
+ background-color: transparentize($color--primary, 0.9) !important; // sass-lint:disable-line no-important
}
}
diff --git a/opentech/static_src/src/sass/public/components/_grid.scss b/opentech/static_src/src/sass/public/components/_grid.scss
index 14aaab89f..ffffac7b0 100644
--- a/opentech/static_src/src/sass/public/components/_grid.scss
+++ b/opentech/static_src/src/sass/public/components/_grid.scss
@@ -143,9 +143,9 @@
@include media-query(tablet-landscape) {
justify-content: space-between;
margin: 3rem 0;
- grid-gap: 35px; // sass-lint:disable-line no-misspelled-properties
- grid-template-columns: repeat(4, 1fr);
text-align: center;
+ grid-template-columns: repeat(4, 1fr);
+ grid-gap: 35px; // sass-lint:disable-line no-misspelled-properties
}
}
}
--
GitLab