From b877eb25d329531828859452a0f22152c90cfe2d Mon Sep 17 00:00:00 2001 From: Todd Dembrey <todd.dembrey@torchbox.com> Date: Fri, 24 May 2019 14:49:09 +0100 Subject: [PATCH] Gh-1191: Do not count disagreements as a full review --- opentech/apply/funds/models/submissions.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/opentech/apply/funds/models/submissions.py b/opentech/apply/funds/models/submissions.py index e36a291fe..8bb320685 100644 --- a/opentech/apply/funds/models/submissions.py +++ b/opentech/apply/funds/models/submissions.py @@ -180,7 +180,9 @@ class ApplicationSubmissionQueryset(JSONOrderable): output_field=IntegerField(), ), review_submitted_count=Subquery( - reviewers.reviewed().values('submission').annotate(count=Count('pk', distinct=True)).values('count'), + reviewers.reviewed().exclude(opinions__opinion=DISAGREE).values('submission').annotate( + count=Count('pk', distinct=True) + ).values('count'), output_field=IntegerField(), ), review_recommendation=Case( -- GitLab