From b01e33b57d5f38addb1922e45a70f626d6bbdb93 Mon Sep 17 00:00:00 2001
From: Chris Lawton <chris.lawton@torchbox.com>
Date: Mon, 11 Jun 2018 17:03:08 +0100
Subject: [PATCH] wrap author name in a span as it may not always be a link
---
.../funds/templates/funds/includes/review_table_row.html | 4 ++--
.../src/sass/apply/components/_reviews-sidebar.scss | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/opentech/apply/funds/templates/funds/includes/review_table_row.html b/opentech/apply/funds/templates/funds/includes/review_table_row.html
index 27bfb289e..d857f48dd 100644
--- a/opentech/apply/funds/templates/funds/includes/review_table_row.html
+++ b/opentech/apply/funds/templates/funds/includes/review_table_row.html
@@ -8,10 +8,10 @@
<td class="reviews-sidebar__author" colspan="2">
{% if request.user.is_apply_staff %}
<a href="{% url 'apply:reviews:review' submission_pk=review.submission.id pk=review.id %}">
- {{ review.author }}
+ <span>{{ review.author }}</span>
</a>
{% else %}
- {{ review.author }}
+ <span>{{ review.author }}</span>
{% endif %}
</td>
<td>{{ review.get_recommendation_display }}</td>
diff --git a/opentech/static_src/src/sass/apply/components/_reviews-sidebar.scss b/opentech/static_src/src/sass/apply/components/_reviews-sidebar.scss
index 1853bd533..57d53ae31 100644
--- a/opentech/static_src/src/sass/apply/components/_reviews-sidebar.scss
+++ b/opentech/static_src/src/sass/apply/components/_reviews-sidebar.scss
@@ -37,7 +37,7 @@
}
&__author {
- a {
+ span {
position: relative;
z-index: 1;
display: block;
@@ -46,7 +46,7 @@
}
&:hover {
- a {
+ span {
display: inline;
overflow: visible;
}
--
GitLab