From a24a2e156c228a77a1f3cc8ed6c79140dd04d9af Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Thu, 23 Aug 2018 15:07:24 +0100
Subject: [PATCH] Fixup tests for changes
---
opentech/apply/review/fields.py | 7 +++++--
opentech/apply/review/tests/test_views.py | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/opentech/apply/review/fields.py b/opentech/apply/review/fields.py
index 8f1e8eee2..169ca4bd9 100644
--- a/opentech/apply/review/fields.py
+++ b/opentech/apply/review/fields.py
@@ -4,7 +4,7 @@ from tinymce import TinyMCE
from django.forms import widgets
from django.utils.safestring import mark_safe
-from opentech.apply.review.options import RATE_CHOICES
+from opentech.apply.review.options import RATE_CHOICES, NA
from opentech.apply.utils.options import MCE_ATTRIBUTES_SHORT
@@ -47,4 +47,7 @@ class ScoredAnswerField(forms.MultiValueField):
super().__init__(fields=fields, *args, **kwargs)
def compress(self, data_list):
- return [data_list[0], int(data_list[1])]
+ if data_list:
+ return [data_list[0], int(data_list[1])]
+ else:
+ return ['', NA]
diff --git a/opentech/apply/review/tests/test_views.py b/opentech/apply/review/tests/test_views.py
index 7413bcc25..9f551d517 100644
--- a/opentech/apply/review/tests/test_views.py
+++ b/opentech/apply/review/tests/test_views.py
@@ -87,7 +87,7 @@ class StaffReviewFormTestCase(BaseViewTestCase):
def test_can_edit_draft_review(self):
ReviewFactory(submission=self.submission, author=self.user, is_draft=True)
- response = self.post_page(self.submission, {'data': 'value'}, 'form')
+ response = self.get_page(self.submission, 'form')
self.assertEqual(response.context['has_submitted_review'], False)
self.assertEqual(response.context['title'], 'Update Review draft')
--
GitLab