diff --git a/hypha/apply/api/v1/determination/serializers.py b/hypha/apply/api/v1/determination/serializers.py index 26cdaf958eee69812807d4bdeaefd0d6dd33fe86..3989821a5659fb1b443ae710d79040b6a23ffdb3 100644 --- a/hypha/apply/api/v1/determination/serializers.py +++ b/hypha/apply/api/v1/determination/serializers.py @@ -13,10 +13,7 @@ class SubmissionDeterminationSerializer(serializers.ModelSerializer): def validate(self, data): validated_data = super().validate(data) - validated_data['form_data'] = { - key: value - for key, value in validated_data.items() - } + validated_data['form_data'] = dict(validated_data.items()) return validated_data def update(self, instance, validated_data): diff --git a/hypha/apply/api/v1/review/serializers.py b/hypha/apply/api/v1/review/serializers.py index be8692b837c2370fbed50c5bf5ab92917df7cc35..80c2795e6ad1105a29ddb52b4e518d97e19af46b 100644 --- a/hypha/apply/api/v1/review/serializers.py +++ b/hypha/apply/api/v1/review/serializers.py @@ -42,10 +42,7 @@ class SubmissionReviewSerializer(serializers.ModelSerializer): def validate(self, data): validated_data = super().validate(data) - validated_data['form_data'] = { - key: value - for key, value in validated_data.items() - } + validated_data['form_data'] = dict(validated_data.items()) return validated_data def update(self, instance, validated_data): diff --git a/hypha/apply/funds/tests/test_views.py b/hypha/apply/funds/tests/test_views.py index 1cc714f0d133be9ade17918db348f3bd90dd5157..de26160d40a89d747db45eeab25dcd6f6a825f50 100644 --- a/hypha/apply/funds/tests/test_views.py +++ b/hypha/apply/funds/tests/test_views.py @@ -238,7 +238,7 @@ class TestStaffSubmissionView(BaseSubmissionViewTestCase): def test_can_create_project(self): # check submission doesn't already have a Project with self.assertRaisesMessage(Project.DoesNotExist, 'ApplicationSubmission has no project.'): - self.submission.project + self.submission.project # noqa: B018 self.post_page(self.submission, { 'form-submitted-project_form': '', diff --git a/hypha/apply/projects/services/sageintacct/wrapper/api_base.py b/hypha/apply/projects/services/sageintacct/wrapper/api_base.py index 03689f6b68b6abe9087176dc00ef998d6029d2e3..67f0e2b2158a5d9acbf999e1c94b7f30e910f690 100644 --- a/hypha/apply/projects/services/sageintacct/wrapper/api_base.py +++ b/hypha/apply/projects/services/sageintacct/wrapper/api_base.py @@ -445,8 +445,11 @@ class ApiBase: if paginated_data['@numremaining'] == '0': break if filtered_total != len(complete_data): - warn(message='Your data may not be complete. Records returned do not equal total query record count', - category=DataIntegrityWarning) + warn( + message='Your data may not be complete. Records returned do not equal total query record count', + category=DataIntegrityWarning, + stacklevel=2 + ) return complete_data def get_lookup(self): diff --git a/hypha/public/people/management/commands/migrate_people.py b/hypha/public/people/management/commands/migrate_people.py index 93f145022e082ca2ea42ca980c001f301ff98b3b..2aaaf3ee8449b9fdfc3222d166c4b3ad416ba95e 100644 --- a/hypha/public/people/management/commands/migrate_people.py +++ b/hypha/public/people/management/commands/migrate_people.py @@ -46,13 +46,13 @@ VALID_IMAGE_MIMETYPES = [ def valid_url_extension(url, extension_list=VALID_IMAGE_EXTENSIONS): - return any([url.endswith(e) for e in extension_list]) + return any(url.endswith(e) for e in extension_list) def valid_url_mimetype(url, mimetype_list=VALID_IMAGE_MIMETYPES): mimetype, encoding = mimetypes.guess_type(url) if mimetype: - return any([mimetype.startswith(m) for m in mimetype_list]) + return any(mimetype.startswith(m) for m in mimetype_list) else: return False diff --git a/hypha/public/projects/management/commands/migrate_projects.py b/hypha/public/projects/management/commands/migrate_projects.py index fc0cc0734ae653dbc1ab44115342ca2f7f98d39b..567124a6647c443c0ba191d3d3000bce674db4f0 100644 --- a/hypha/public/projects/management/commands/migrate_projects.py +++ b/hypha/public/projects/management/commands/migrate_projects.py @@ -42,13 +42,13 @@ VALID_IMAGE_MIMETYPES = [ def valid_url_extension(url, extension_list=VALID_IMAGE_EXTENSIONS): - return any([url.endswith(e) for e in extension_list]) + return any(url.endswith(e) for e in extension_list) def valid_url_mimetype(url, mimetype_list=VALID_IMAGE_MIMETYPES): mimetype, encoding = mimetypes.guess_type(url) if mimetype: - return any([mimetype.startswith(m) for m in mimetype_list]) + return any(mimetype.startswith(m) for m in mimetype_list) else: return False