From 90b593c2ee2e0deb029ac7ce538fad83086a378a Mon Sep 17 00:00:00 2001 From: Erin Mullaney <erin.mullaney@torchbox.com> Date: Tue, 19 Feb 2019 08:58:41 -0500 Subject: [PATCH] #960 test updates --- opentech/apply/review/tests/test_views.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/opentech/apply/review/tests/test_views.py b/opentech/apply/review/tests/test_views.py index 895346cf0..3036cfbf9 100644 --- a/opentech/apply/review/tests/test_views.py +++ b/opentech/apply/review/tests/test_views.py @@ -1,12 +1,13 @@ from django.urls import reverse +from opentech.apply.activity.models import Activity from opentech.apply.funds.tests.factories.models import ApplicationSubmissionFactory from opentech.apply.users.tests.factories import StaffFactory, UserFactory from opentech.apply.utils.testing.tests import BaseViewTestCase from .factories import ReviewFactory, ReviewFormFieldsFactory, ReviewFormFactory -from ..models import Review -from ..options import NA +from ..models import Review, ReviewOpinion +from ..options import NA, AGREE class StaffReviewsTestCase(BaseViewTestCase): @@ -221,7 +222,7 @@ class StaffReviewOpinionCase(BaseViewTestCase): def get_kwargs(self, instance): return {'pk': instance.id, 'submission_pk': instance.submission.id} - def test_can_see_opinion_buttons_on_another_reviewers_review(self): + def test_can_see_opinion_buttons_on_others_review(self): staff = StaffFactory() review = ReviewFactory(submission=self.submission, author=staff, recommendation_yes=True) response = self.get_page(review) @@ -233,3 +234,11 @@ class StaffReviewOpinionCase(BaseViewTestCase): response = self.get_page(review) self.assertNotContains(response, '<button name="opinion"') self.assertNotIn('opinion_choices', response.context_data) + + def test_can_add_opinion_to_others_review(self): + staff = StaffFactory() + review = ReviewFactory(submission=self.submission, author=staff, recommendation_yes=True) + self.post_page(review, {'opinion': AGREE}) + self.assertTrue('agrees' in Activity.objects.first().message) + self.assertEqual(ReviewOpinion.objects.all().count(), 1) + self.assertEqual(ReviewOpinion.objects.first().opinion, AGREE) -- GitLab