From 5792dc8c4fa2a1f974eb4271d22ed0281805db00 Mon Sep 17 00:00:00 2001
From: Erin Mullaney <erin.mullaney@torchbox.com>
Date: Wed, 13 Feb 2019 07:28:37 -0500
Subject: [PATCH] #957 another test for adding reviewers with and without roles
---
opentech/apply/funds/tests/test_views.py | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/opentech/apply/funds/tests/test_views.py b/opentech/apply/funds/tests/test_views.py
index cd63b1536..4f2db9b73 100644
--- a/opentech/apply/funds/tests/test_views.py
+++ b/opentech/apply/funds/tests/test_views.py
@@ -295,6 +295,18 @@ class TestReviewersUpdateView(BaseSubmissionViewTestCase):
self.assertEqual(submission.reviewers.all().count(), 2)
self.assertIn(self.staff[0], submission.reviewers.all())
+ def test_lead_adds_two_roles_one_reviewer_and_a_new_review_comes_in(self):
+ submission = ApplicationSubmissionFactory(lead=self.user, status='external_review', workflow_stages=2)
+
+ self.post_form(submission, reviewer_roles=[self.staff[0], self.staff[1]], reviewers=[self.reviewers[0]])
+ self.assertEqual(submission.reviewers.all().count(), 3)
+
+ # Add a review from a new reviewer who isn't assigned
+ review = ReviewFactory(submission=submission, author=self.reviewers[1])
+
+ # Now there should be 4 reviewers assigned, because an outsider reviewed
+ self.assertEqual(submission.reviewers.all().count(), 4)
+
class TestApplicantSubmissionView(BaseSubmissionViewTestCase):
user_factory = UserFactory
--
GitLab