From 572d6b64cd1d3f1885c99b296d1dcbc0c677cf25 Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Thu, 19 Jul 2018 08:26:20 +0100
Subject: [PATCH] fixup! Refactor the tests to use use the form not the view
---
opentech/apply/users/tests/test_forms.py | 6 ++----
opentech/apply/users/tests/test_views.py | 8 --------
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/opentech/apply/users/tests/test_forms.py b/opentech/apply/users/tests/test_forms.py
index 76b65bddb..03860d17e 100644
--- a/opentech/apply/users/tests/test_forms.py
+++ b/opentech/apply/users/tests/test_forms.py
@@ -1,10 +1,8 @@
-from django import forms
from django.forms.models import model_to_dict
from django.test import TestCase
-from django.urls import reverse
from ..forms import ProfileForm
-from .factories import OAuthUserFactory, StaffFactory, UserFactory
+from .factories import StaffFactory, UserFactory
class BaseTestProfileForm(TestCase):
@@ -46,7 +44,7 @@ class TestProfileForm(BaseTestProfileForm):
self.assertNotEqual(self.user.slack, slack_name)
-class TestStaffProfileView(BaseTestProfileForm):
+class TestStaffProfileForm(BaseTestProfileForm):
def setUp(self):
self.staff = StaffFactory()
diff --git a/opentech/apply/users/tests/test_views.py b/opentech/apply/users/tests/test_views.py
index b1f6bffa5..443f007fa 100644
--- a/opentech/apply/users/tests/test_views.py
+++ b/opentech/apply/users/tests/test_views.py
@@ -1,8 +1,6 @@
-from django.forms.models import model_to_dict
from django.test import TestCase
from django.urls import reverse
-from ..forms import ProfileForm
from .factories import OAuthUserFactory, StaffFactory, UserFactory
@@ -11,12 +9,6 @@ class BaseTestProfielView(TestCase):
def setUpTestData(cls):
cls.url = reverse('users:account')
- def form_data(self, user, **values):
- fields = ProfileForm.Meta.fields
- data = model_to_dict(user, fields)
- data.update(**values)
- return data
-
class TestProfileView(BaseTestProfielView):
def setUp(self):
--
GitLab