From 56d4d3dc756947296ad4715c5e3fab42aba43183 Mon Sep 17 00:00:00 2001 From: Chris Lawton <chris.lawton@torchbox.com> Date: Fri, 1 Mar 2019 16:11:14 +0000 Subject: [PATCH] ensure the review bar header doesn't render twice --- .../src/app/src/containers/ReviewInformation.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/opentech/static_src/src/app/src/containers/ReviewInformation.js b/opentech/static_src/src/app/src/containers/ReviewInformation.js index e4d8b77e6..3be36078d 100644 --- a/opentech/static_src/src/app/src/containers/ReviewInformation.js +++ b/opentech/static_src/src/app/src/containers/ReviewInformation.js @@ -31,7 +31,7 @@ const ReviewInformation = ({ data }) => { } const renderReviewBlock = (reviewers) => { - return <ReviewBlock score={data.score} recommendation={data.recommendation.display}> + return <> {reviewers.map(reviewer => { const review = data.reviews.filter(review => review.authorId === reviewer.id)[0]; @@ -55,7 +55,7 @@ const ReviewInformation = ({ data }) => { })} </Review> })} - </ReviewBlock> + </> } const orderedStaff = orderPeople(staff); @@ -64,8 +64,11 @@ const ReviewInformation = ({ data }) => { return ( <> <h1>Reviews & assigness</h1> - {renderReviewBlock(orderedStaff)} - {renderReviewBlock(orderedNonStaff)} + <ReviewBlock score={data.score} recommendation={data.recommendation.display}> + {renderReviewBlock(orderedStaff)} + <hr /> + {renderReviewBlock(orderedNonStaff)} + </ReviewBlock> </> ) } -- GitLab