From 4da466b0151fbb2863ad4ce5e5af3ae359576ac3 Mon Sep 17 00:00:00 2001
From: Fredrik Jonsson <frjo@xdeb.org>
Date: Wed, 6 May 2020 20:32:01 +0200
Subject: [PATCH] Make use of has_all_reviewer_roles_assigned.
---
hypha/apply/funds/views.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hypha/apply/funds/views.py b/hypha/apply/funds/views.py
index ad35cc75b..83dad0ce8 100644
--- a/hypha/apply/funds/views.py
+++ b/hypha/apply/funds/views.py
@@ -92,9 +92,8 @@ from .workflow import (
class UpdateReviewersMixin:
def set_status_after_reviewers_assigned(self, submission):
- # Check if two internal reviewers have been selected.
- internal_reviewers_count = submission.assigned.with_roles().count()
- if internal_reviewers_count > 1:
+ # Check if all internal reviewers have been selected.
+ if submission.has_all_reviewer_roles_assigned:
# Automatic workflow actions.
action = None
if submission.status == INITIAL_STATE:
--
GitLab