From 0a21ec10f2b26277b642eb56092f37555d147060 Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Tue, 19 Feb 2019 17:13:35 +0000
Subject: [PATCH] fixup! Gh-858: make sure we handle batch transition in kwargs
---
opentech/apply/activity/messaging.py | 1 -
opentech/apply/activity/tests/test_messaging.py | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/opentech/apply/activity/messaging.py b/opentech/apply/activity/messaging.py
index 1af108b16..3c5670c57 100644
--- a/opentech/apply/activity/messaging.py
+++ b/opentech/apply/activity/messaging.py
@@ -532,7 +532,6 @@ class EmailAdapter(AdapterBase):
} for reviewer, submissions in reviewers_to_message.items()
]
-
def reviewers(self, submission):
return [
reviewer.email
diff --git a/opentech/apply/activity/tests/test_messaging.py b/opentech/apply/activity/tests/test_messaging.py
index e2c8b6318..c7e1d8540 100644
--- a/opentech/apply/activity/tests/test_messaging.py
+++ b/opentech/apply/activity/tests/test_messaging.py
@@ -247,13 +247,13 @@ class TestActivityAdapter(TestCase):
def test_internal_transition_kwarg_for_invisible_transition(self):
submission = ApplicationSubmissionFactory(status='post_review_discussion')
- kwargs = self.adapter.extra_kwargs(MESSAGES.TRANSITION, submission=submission)
+ kwargs = self.adapter.extra_kwargs(MESSAGES.TRANSITION, submission=submission, submissions=None)
self.assertEqual(kwargs['visibility'], INTERNAL)
def test_public_transition_kwargs(self):
submission = ApplicationSubmissionFactory()
- kwargs = self.adapter.extra_kwargs(MESSAGES.TRANSITION, submission=submission)
+ kwargs = self.adapter.extra_kwargs(MESSAGES.TRANSITION, submission=submission, submissions=None)
self.assertNotIn('visibility', kwargs)
--
GitLab