From 04be0358975bb207b6ce15b01e51bea8adcbe00b Mon Sep 17 00:00:00 2001
From: Fredrik Jonsson <frjo@xdeb.org>
Date: Mon, 19 Aug 2019 15:33:17 +0200
Subject: [PATCH] Updated test to check that NA is included and not excluded as
before.
---
opentech/apply/review/tests/test_views.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/opentech/apply/review/tests/test_views.py b/opentech/apply/review/tests/test_views.py
index 7f4614e62..63eec5e6e 100644
--- a/opentech/apply/review/tests/test_views.py
+++ b/opentech/apply/review/tests/test_views.py
@@ -163,20 +163,20 @@ class TestReviewScore(BaseViewTestCase):
review = self.submit_review_scores()
self.assertEqual(review.score, NA)
- def test_na_not_included_in_review_average(self):
+ def test_na_included_in_review_average(self):
review = self.submit_review_scores(NA, 5)
- self.assertEqual(review.score, 5)
+ self.assertEqual(review.score, 2.5)
- def test_na_not_included_reviews_average(self):
+ def test_na_included_reviews_average(self):
self.submit_review_scores(NA)
- self.assertIsNone(Review.objects.score())
+ self.assertIsNotNone(Review.objects.score())
- def test_na_not_included_multiple_reviews_average(self):
+ def test_na_included_multiple_reviews_average(self):
self.submit_review_scores(NA)
self.submit_review_scores(5)
self.assertEqual(Review.objects.count(), 2)
- self.assertEqual(Review.objects.score(), 5)
+ self.assertEqual(Review.objects.score(), 2.5)
class UserReviewFormTestCase(BaseViewTestCase):
--
GitLab